[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v2 2/2] get rid of hostregs_helper.h

From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH v2 2/2] get rid of hostregs_helper.h
Date: Thu, 25 Feb 2010 14:11:31 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1

On 02/25/2010 02:04 PM, Michael S. Tsirkin wrote:
Clobbering memory
>  is not necessary since we are only caring about blocking assignments of
>  "env", which is by definition in a register

Then I think you should add that as a clobber. Otherwise what prevents the
compiler from reordering this asm wrt assignments?

That old-style asms block scheduling of _anything_ across it (like "barrier()" in the Linux kernel). So, it is actually slightly stricter than what was there before.

I should have made clear in the commit message that this is the only change wrt hostregs_helper.h.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]