[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in hu
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor |
Date: |
Thu, 4 Mar 2010 17:50:20 -0300 |
On Thu, 4 Mar 2010 16:56:49 +0100
Markus Armbruster <address@hidden> wrote:
> While fully converted handlers are not supposed to print anything when
> running in a QMP monitor, they are free to print in a human monitor.
I disagree.
One of the key decisions behind the new Monitor design is that handlers
are part of common code. User printing is output-specific and should not
be done by handlers.
One of the problems with this layer violation is that the consumer of this
data might not be what you have assumed. For example, it has been suggested
that we could move the qemu shell out of qemu in the future. In this case,
this kind of information _could_ be useful.
Another important problem is that free printing like this is error-prone
as it's not at all clear what could be printed and there's no way to catch
mistakes mechanically. Not to mention that this is for sure going to used
by those who want to ignore QMP completely.
I'm ok with shallow conversion, provided that handler_audit() is there to
warn us about the job to be done.
- [Qemu-devel] [PATCH 19/50] error: Include the program name in error messages to stderr, (continued)
- [Qemu-devel] [PATCH 19/50] error: Include the program name in error messages to stderr, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 38/50] error: New error_printf_unless_qmp(), Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 20/50] error: Track locations in configuration files, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 46/50] qemu-option: Move the implied first name into QemuOptsList, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 22/50] error: Track locations on command line, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 48/50] monitor: New argument type 'O', Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 29/50] error: Polish human-readable error descriptions, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 21/50] QemuOpts: Fix qemu_config_parse() to catch file read errors, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 32/50] qdev: convert setting device properties to QError, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 28/50] error: Let converted handlers print in human monitor, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 44/50] error: Convert do_device_add() to QError, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 37/50] qdev: Convert qbus_find() to QError, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 43/50] Revert "qdev: Use QError for 'device not found' error", Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 33/50] qdev: Relax parsing of bus option, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 50/50] monitor: convert do_device_add() to QObject, Markus Armbruster, 2010/03/04