[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in hu
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor |
Date: |
Fri, 5 Mar 2010 12:43:00 -0300 |
On Thu, 4 Mar 2010 17:50:20 -0300
Luiz Capitulino <address@hidden> wrote:
> On Thu, 4 Mar 2010 16:56:49 +0100
> Markus Armbruster <address@hidden> wrote:
>
> > While fully converted handlers are not supposed to print anything when
> > running in a QMP monitor, they are free to print in a human monitor.
>
> I disagree.
I've talked to Markus by irc about this one and he convinced me that
this is the best solution for the immediate term.
Actually, I found out that only error is printed in the human monitor
(through qerror_report()) so this is not as serious as I thought at first.
So, I won't nack it and the bigger mid-term discussion we should have
is whether or not it's ok to mix qerror_report(), error_printf() &
friends in handlers.
- [Qemu-devel] [PATCH 46/50] qemu-option: Move the implied first name into QemuOptsList, (continued)
- [Qemu-devel] [PATCH 46/50] qemu-option: Move the implied first name into QemuOptsList, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 22/50] error: Track locations on command line, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 48/50] monitor: New argument type 'O', Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 29/50] error: Polish human-readable error descriptions, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 21/50] QemuOpts: Fix qemu_config_parse() to catch file read errors, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 32/50] qdev: convert setting device properties to QError, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 28/50] error: Let converted handlers print in human monitor, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 44/50] error: Convert do_device_add() to QError, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 37/50] qdev: Convert qbus_find() to QError, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 43/50] Revert "qdev: Use QError for 'device not found' error", Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 33/50] qdev: Relax parsing of bus option, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 50/50] monitor: convert do_device_add() to QObject, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 27/50] monitor: New monitor_cur_is_qmp(), Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 30/50] error: New QERR_PROPERTY_NOT_FOUND, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 25/50] qdev: Hide "no_user" devices from users, Markus Armbruster, 2010/03/04