[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots |
Date: |
Sun, 25 Apr 2010 16:29:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 04/25/2010 04:57 PM, Jan Kiszka wrote:
>>
>>> It's still a good idea. The current API assumes that there will be only
>>> one slot-based client (or that multiple clients will keep the refcount
>>> themselves).
>>>
>>> After the bytemap -> multiple bitmaps conversion this can be
>>> extended to
>>> each client getting its own bitmap (and therefore, s/refcount/list of
>>> bitmaps/ and s/!refcount/list_empty()/).
>>>
>>>
>> No concerns if
>> - there is an existing use case for multiple clients, at least in
>> qemu-kvm
>>
>
> There isn't. But I don't like hidden breakage.
It's (so far) an unproblematic API property we can document. I don't
like changing APIs just for "there might be the case that...".
>
>> - the logging API is consistently converted, not just extended
>> (IOW, migration_log is converted to logging_count)
>>
>
> migration_log needs to remain global, since we want hotplug memory to
> autostart logging.
Can't follow yet, what will be the usage pattern of
kvm_set_migration_log? Or would the hotplug code require a separate
interface? Is it already the multi-client use case I'm looking for?
>
>> - someone signs he checked that current use of start/stop in qemu is
>> completely symmetrical (I think to remember this used to be not the
>> case, but I might be wrong)
>>
>
> I remember this too. Marcelo?
>
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] [uq/master patch 2/5] kvm: add logging count to slots, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/24
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots,
Jan Kiszka <=
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/26
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Marcelo Tosatti, 2010/04/26
[Qemu-devel] [uq/master patch 4/5] kvm: port qemu-kvm's bitmap scanning, Marcelo Tosatti, 2010/04/23
[Qemu-devel] [uq/master patch 1/5] vga: fix typo in length passed to kvm_log_stop, Marcelo Tosatti, 2010/04/23