|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 07/39] do not pass bogus $(SRC_PATH) include paths to cc during configure |
| Date: | Wed, 13 Oct 2010 09:25:12 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3 |
On 10/12/2010 09:09 PM, Blue Swirl wrote:
QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS" QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS" QEMU_CFLAGS="-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS"Aren't the above also CPP flags?
Yes, the difference is that the QEMU_CPPFLAGS are not used in the configure tests. Instead, you need to use the above -D flags because they affect the system headers. I'll rename QEMU_CPPFLAGS to QEMU_INCLUDES.
-LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $@ $(1) $(LIBS)," LINK $(TARGET_DIR)$@") +LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_CPPFLAGS) $(CFLAGS) $(LDFLAGS) -o $@ $(1) $(LIBS)," LINK $(TARGET_DIR)$@")I don't think the linker will use any CPP flags.
Yeah, though it doesn't use most CFLAGS either. I'll remove the CPPFLAGS only, in both patches.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |