[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 04/22] Leave inner main_loop faster on pending r
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 04/22] Leave inner main_loop faster on pending requests |
Date: |
Mon, 31 Jan 2011 12:22:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-01-31 10:52, Avi Kivity wrote:
> On 01/27/2011 03:09 PM, Jan Kiszka wrote:
>> If there is any pending request that requires us to leave the inner loop
>> if main_loop, makes sure we do this as soon as possible by enforcing
>> non-blocking IO processing.
>>
>> At this change, move variable definitions out of the inner loop to
>> improve readability.
>>
>> Signed-off-by: Jan Kiszka<address@hidden>
>> ---
>> vl.c | 11 +++++++----
>> 1 files changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 5fad700..2ebc55b 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1384,18 +1384,21 @@ qemu_irq qemu_system_powerdown;
>>
>> static void main_loop(void)
>> {
>> + bool nonblocking = false;
>> +#ifdef CONFIG_PROFILER
>> + int64_t ti;
>> +#endif
>> int r;
>>
>> qemu_main_loop_start();
>>
>> for (;;) {
>> do {
>> - bool nonblocking = false;
>> -#ifdef CONFIG_PROFILER
>> - int64_t ti;
>> -#endif
>> #ifndef CONFIG_IOTHREAD
>> nonblocking = cpu_exec_all();
>> + if (!vm_can_run()) {
>> + nonblocking = true;
>> + }
>
> Doesn't this cause vmstop to spin? We'll never execute
> main_loop_wait(false) if I read the code correctly?
>
The code path is not changed, we just poll instead of wait in
main_loop_wait.
Also, I didn't get your error scenario yet. Even if we left the loop
here, what magic would main_loop_wait do to vmstop processing? The stop
request is handled outside the loop, that's why we should leave ASAP.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, (continued)
- [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Avi Kivity, 2011/01/31
- [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Jan Kiszka, 2011/01/31
- Re: [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Stefan Hajnoczi, 2011/01/31
- Re: [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Jan Kiszka, 2011/01/31
- Re: [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Stefan Hajnoczi, 2011/01/31
- [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Avi Kivity, 2011/01/31
- [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Jan Kiszka, 2011/01/31
- [Qemu-devel] Re: [PATCH v3 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD, Avi Kivity, 2011/01/31
[Qemu-devel] [PATCH 04/22] Leave inner main_loop faster on pending requests, Jan Kiszka, 2011/01/27
[Qemu-devel] [PATCH 11/22] kvm: Refactor qemu_kvm_eat_signals, Jan Kiszka, 2011/01/27
[Qemu-devel] [PATCH 19/22] kvm: Remove static return code of kvm_handle_io, Jan Kiszka, 2011/01/27
[Qemu-devel] [PATCH 05/22] kvm: Report proper error on GET_VCPU_MMAP_SIZE failures, Jan Kiszka, 2011/01/27
[Qemu-devel] [PATCH 06/22] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn, Jan Kiszka, 2011/01/27
[Qemu-devel] [PATCH 13/22] Set up signalfd under !CONFIG_IOTHREAD, Jan Kiszka, 2011/01/27
[Qemu-devel] [PATCH 16/22] Introduce VCPU self-signaling service, Jan Kiszka, 2011/01/27
[Qemu-devel] [PATCH 02/22] Stop current VCPU on synchronous reset requests, Jan Kiszka, 2011/01/27