[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver |
|
Date: |
Sun, 20 Feb 2011 19:45:42 +0100 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, Feb 20, 2011 at 08:39:20PM +0200, Vasily Khoruzhick wrote:
> On Sunday 20 February 2011 20:24:46 Aurelien Jarno wrote:
>
> > The fix looks fine, but the resulting code is probably over
> > engineered... What about:
> >
> > s->enable = (value & 9) == 1;
> >
> > ?
>
> Looks OK to me.
>
Can you please provide a new version with that code instead, I'll apply
it.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net