[Qemu-devel] Re: [PATCH 19/26] Add PAPR H_VIO_SIGNAL hypercall and infrastructure for VIO interrupts

[David Gibson]

On Wed, Mar 16, 2011 at 04:49:07PM +0100, Alexander Graf wrote:
> On 03/16/2011 05:56 AM, David Gibson wrote:
[snip]
> >+        return H_PARAMETER;;
> >+
> >+    dev->signal_state = mode;
> 
> No need to notify the device?

No, at the point it would send an interrupt the device checks
signal_state.

That said, I was considering another cleanup to the signal code to
have the devices use a helper function checking signal_state, and also
allowing multiple interrupts for a VIO device.  Not sure if it's worth
folding that into this series or doing it as a later extension.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson