[Qemu-devel] Re: [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState

[Juan Quintela]

Peter Maydell <address@hidden> wrote:
> On 23 March 2011 00:16, Anthony Liguori <address@hidden> wrote:
>> +    if (old_version != new_version) {
>> +        g_error("Version %d of device `%s' is available in QEMU, but schema 
>> still reports %d, please update schema.\n",
>> +                new_version, device, old_version);
>> +    }
>
> Might be nice for these "please update" error messages to
> include a pointer to a docs file explaining in more detail
> how to do that?
> (also >80 char line ;-))
>
>> diff --git a/vmstate/schema.json b/vmstate/schema.json
>> new file mode 100644
>> index 0000000..23483ab
>> --- /dev/null
>> +++ b/vmstate/schema.json
>> @@ -0,0 +1,1176 @@
>> +{
>> +    "cpu": {
>> +        "mcg_cap": "uint64",
>> +        "a20_mask": "int32",
>> +        "tsc_offset": "uint64",
>
> This schema file appears to be board-specific (or at least
> x86-specific) -- shouldn't the cpu/board/whatever name
> be in the filename, so we have scope to expand the test
> to checking migration issues for other platforms too?
>
> (I don't care much about ARM migration breakages just at the
> moment but I suspect that it will be becoming more important
> by this time next year...)
>
> Also since this looks like an autogenerated file that's going
> to be going into version control maybe it should have a
> comment header at the top of the "autogenerated, do not edit
> by hand!" type.

I agree with you.  Just passing another argument to all programs telling
what we are talking about would be much better for this.

And we need (at least) x86_64 & i386 (this ones are supposed to work).
ARM people are sending lots of vmstate changes, I guess/hope that
somebody is trying to get it working.

/me looks at Peter O:-), hint, hint, ...

Any idea if there are images for testing ARM?

Later, Juan.