[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus |
Date: |
Mon, 28 Mar 2011 14:01:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 |
On 03/23/11 14:19, Alon Levy wrote:
> A CCID device is a smart card reader. It is a USB device, defined at [1].
> This patch introduces the usb-ccid device that is a ccid bus. Next patches
> will
> introduce two card types to use it, a passthru card and an emulated card.
>
> [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_Rev110.
>
> Signed-off-by: Alon Levy <address@hidden>
This looks ok to me now - I noticed that the comments in the header file
refers to u8/u16/u32 for types, even though the code uses
uint{8,16,32}_t, but I don't think that warrants a fix.
If the comment goes in, please fix the spelling of my name.
Reviewed-by: Jes Sorensen <address@hidden>
- Re: [Qemu-devel] [PATCH v23 01/11] trace: move trace objects from Makefile to Makefile.objs, (continued)
- [Qemu-devel] [PATCH v23 02/11] qemu-thread.h: include inttypes.h, Alon Levy, 2011/03/23
- [Qemu-devel] [PATCH v23 04/11] introduce libcacard/vscard_common.h, Alon Levy, 2011/03/23
- [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus, Alon Levy, 2011/03/23
- Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus,
Jes Sorensen <=
- Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus, Alon Levy, 2011/03/28
- Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus, Alon Levy, 2011/03/28
- Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus, Jes Sorensen, 2011/03/28
- Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus, Blue Swirl, 2011/03/28
- Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus, Alon Levy, 2011/03/28
- Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus, Blue Swirl, 2011/03/28
[Qemu-devel] [PATCH v23 08/11] libcacard: add passthru, Alon Levy, 2011/03/23