Re: [Qemu-devel] [PATCH v23 08/11] libcacard: add passthru

[Jes Sorensen]

On 03/28/11 17:21, Alon Levy wrote:
>> > Where does this odd LONG type come from? I think Windows uses LONG so
>> > having your own type would conflict with that, and of course we don't
>> > really want Windows types directly in QEMU either, so I am curious?
>> > 
> This comes from pcsclite (which means I need to add the dependency to 
> configure,
> I'll fix this). From there it comes via an include called wintypes.h. the 
> PCSC API
> is actually a copy of a microsoft API, so it makes sense that it uses those 
> types.
> 
> On windows pcsclite won't be needed, since it has a native equivalent API, so 
> there
> won't be a redefinition of LONG.
> 
> So the real fix is that I need to add yet another dependency for qemu's 
> configure,
> for pcsc-lite - but right now the whole libcacard/passthru.c is protected by 
> an
> "#ifdef USE_PASSTHRU", which we don't define - so in effect this is currently 
> dead
> code. I could even just remove this commit in its entirety atm, maybe best? 
> Notice
> that has nothing to do with ccid-card-emulated or with ccid-card-passthru. I 
> will
> need it later, but I need to add the pcsclite configure check anyway. So is 
> this ok,
> I'll drop this patch?
> 

Interesting - yeah if the code isn't necessary, lets drop it for now. It
will be easier to get this in now, and the extra bits later when they
are ready.

Cheers,
Jes