[Qemu-devel] Re: [PATCH v2 3/5] hw/sun4m: Move QEMUMachine structs into sun4*_hwdef structs

[Peter Maydell]

On 28 March 2011 18:58, Blue Swirl <address@hidden> wrote:
> On Mon, Mar 28, 2011 at 8:36 PM, Peter Maydell <address@hidden> wrote:
>> On 28 March 2011 18:31, Blue Swirl <address@hidden> wrote:
>>> On Mon, Mar 28, 2011 at 4:44 PM, Peter Maydell <address@hidden> wrote:
>>>> Combine the per-machine QEMUMachine struct into the per-machine
>>>> sun4*_hwdef struct. This requires some moving around of init functions
>>>> to avoid forward references. We also have to move the 'const'
>>>> attribute from the whole sun4*_hwdef[] array to the individual fields
>>>> of the structure, because QEMUMachine is not const.
>>>
>>> Maybe QEMUMachine should be made const instead? The data does not ever
>>> need to change.
>>
>> I thought about that, but we need to fill in the 'next' links when
>> we do qemu_register_device().
>
> The list could be kept separate from the structure.

Well, we could, but I tend to find separate list headers a bit ugly.

-- PMM