qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qxl: move qemu_spice_add_memslot call out of qx


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] qxl: move qemu_spice_add_memslot call out of qxl_add_memslot
Date: Thu, 07 Jul 2011 09:39:34 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Red Hat/3.1.11-2.el6_1 Thunderbird/3.1.11

  Hi,

-static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta)
+static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta,
+                            QXLDevMemSlot *memslot)

-        qxl_add_memslot(d, val, 0);
+        qxl_add_memslot(d, val, 0,&memslot);
+        qemu_spice_add_memslot(&d->ssd,&memslot);

Do we still need this and the simliar patches? Given that we don't call qemu_spice_add_memslot() from another thread any more we could just pass in a async flag to qxl_add_memslot().

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]