|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API |
| Date: | Tue, 12 Jul 2011 10:14:49 +0300 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 |
On 07/12/2011 01:03 AM, malc wrote:
> > Here's a new version: This one looks acceptable[1], original submission said: "fixes BAR sizing as well." what was wrong with it?
The nabm BAR, for example, was registered as 64 bytes of byte ioports, 128 bytes of word ioports, and 256 bytes of long ioports. I expect this was an error.
The new patch preserves the error.
[..snip..] P.S. Sans minor inconsistency with trailing commas.
Where I expect more fields, I leave a trailing comma. It makes further patches nicer.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| [Prev in Thread] | Current Thread | [Next in Thread] |