[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

From: Liu, Jinsong
Subject: Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm
Date: Sat, 10 Sep 2011 02:21:49 +0800

Marcelo Tosatti wrote:
> On Fri, Sep 09, 2011 at 01:12:51AM +0800, Liu, Jinsong wrote:
>>>>> --- a/arch/x86/include/asm/msr-index.h
>>>>> +++ b/arch/x86/include/asm/msr-index.h
>>>>> @@ -229,6 +229,8 @@
>>>>>  #define MSR_IA32_APICBASE_ENABLE (1<<11)
>>>>>  #define MSR_IA32_APICBASE_BASE           (0xfffff<<12)
>>>>> +#define MSR_IA32_TSCDEADLINE             0x000006e0
>>>>> +
>>>>>  #define MSR_IA32_UCODE_WRITE             0x00000079
>>>>>  #define MSR_IA32_UCODE_REV               0x0000008b
>>>> Need to add to msrs_to_save so live migration works.
>>> MSR must be explicitly listed in qemu, also.
>> Marcelo, seems MSR don't need explicitly list in qemu?
>> KVM side adding MSR_IA32_TSCDEADLINE to msrs_to_save is enough. Qemu
>> will get it through KVM_GET_MSR_INDEX_LIST. Do I miss something?
> Notice in target-i386/kvm.c the KVM_GET_MSR_INDEX_LIST list is only
> used for MSR_STAR/MSR_HSAVE_PA presence detection.

Yes, but in kvm/libkvm/libkvm-x86.c the KVM_GET_MSR_INDEX_LIST get all list.
That's what I want to make clear --> which one live migration use?

> Do you do need to explicitly add MSR_IA32_TSCDEADLINE to
> kvm_get_msrs/kvm_put_msrs routines.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]