[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer
Date: Mon, 12 Sep 2011 12:11:32 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 09/12/2011 12:01 PM, Jan Kiszka wrote:
On 2011-09-12 08:43, Richard Henderson wrote:
>  On 09/11/2011 09:31 PM, Blue Swirl wrote:
>>  Field 'offset' is always zero, maybe that is not interesting. Will it
>>  become one day?
>  It's not always zero, but only used by certain devices.

I do not see any users, neither upstream nor in Avi's tree.

There aren't.

To my (semi-)understanding, offset should correlate to region_offset of
cpu_register_physical_memory_offset: legacy device models require this
to be 0 as they expect an absolute memory address passed to their
handler, in contrast to a normal one that is relative to the regions
base. But I do not see how the memory region offset actually helps here.

mr->offset is added to the address in memory_region_{read,write}_thunk_n().

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]