[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 50/58] pseries: Update SLOF firmware image

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 50/58] pseries: Update SLOF firmware image
Date: Wed, 14 Sep 2011 07:59:28 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 09/14/2011 07:28 AM, Peter Maydell wrote:
On 14 September 2011 13:24, Alexander Graf<address@hidden>  wrote:
Am 14.09.2011 um 13:01 schrieb Peter Maydell<address@hidden>:
I confess to not really understanding how we keep the git
submodules and the binary blobs in sync, but shouldn't there
be a reference in the commit message to the git commit hash
for the slof sources corresponding to this blob, and maybe
also an update to roms/SLOF here? (cf commit d67c3f2c for
example) ?

Oh? Since I have absolutely no idea on git submodules, it might
be helpful to add some description on how to do a blob update
into README?

Sounds like a good idea -- I think Anthony is the expert here.

You should be able to just checkout the desired version of the submodule (you may need to refetch from git.qemu.org), then build the binary and copy the results to pc-bios/. Then in the top level, do a single commit that includes the submodule commit change and the new binary blob.

For seabios, it would look something like:

$ cd roms/seabios
$ git checkout v0.7.0
$ make
$ cp out/bios.bin ../../pc-bios/bios.bin
$ cd ../..
$ git commit -a -m 'Update seabios to newest version'

I use the following script to generate the seabios commit message which gives a short summary of the changes:


git --git-dir=roms/seabios/.git log --pretty=format:' - %h %s' $(git diff roms/seabios | grep '^-Subproject commit' | cut -f3 -d' ')..$(git diff roms/seabios | grep '^+Subproject commit' | cut -f3 -d' ')


Anthony Liguori

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]