[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/14] qdev: take ownership of id pointer

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 04/14] qdev: take ownership of id pointer
Date: Mon, 19 Sep 2011 11:27:25 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 09/19/2011 02:34 AM, Gerd Hoffmann wrote:
On 09/16/11 18:00, Anthony Liguori wrote:
qdev has this quirk that it owns a seemingly arbitrary QemuOpts pointer. That's
because qdev expects a static string for the id (which really makes no sense
since ids are supposed to be provided by the user). Instead of managing just
the id pointer, we currently take ownership of the entire QemuOpts structure
that was used to create the device just to keep the name around.

FYI: Keeping the pointer to the QemuOpts has one more reason: It will free the
QemuOpts on hot-unplug, which is needed to free the id from QemuOpts point of
view, which in turn allows to re-use the id when hot-plugging the same (or
another) device later on.

You mean, tie QemuOpts life cycle to devices life cycle such that you cannot accidentally create a non-device QemuOpts that conflicts with the id of a device?


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]