[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation
Date: Tue, 27 Sep 2011 09:30:37 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 09/27/2011 06:50 AM, Peter Maydell wrote:
On 27 September 2011 12:25, Michael S. Tsirkin<address@hidden>  wrote:
e1000 spec says CTRL.RST write should have the same effect
as bus reset, except that is preserves PCI Config.
Reset device registers and interrupts.

Fix suggested by Andy Gospodarek<address@hidden>

Doesn't this have the same effect as this patch:

except that it's harder to read because it's moved a lot
of code around in the file?

(I think you have an extra qemu_set_irq() call in there,
actually. But it was hard to find. Also your code has the
bug that was in earlier revisions of Anthony's patch where
after doing the reset you fall through and allow other bits
in the ctrl register to be set.)

I didn't see your note which said not to rend the patch unless I produce a compiler that issues a warning. Since Anthony P. was going to resubmit, I never looked into it further.

I honestly don't care at this point which patch gets merged.


Anthony Liguori

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]