Re: [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snapshots

[Stefan Hajnoczi]

On Fri, Nov 18, 2011 at 6:28 PM, Kevin Wolf <address@hidden> wrote:
> Kevin Wolf (9):
>  qcow2: Return real error code in qcow2_read_snapshots
>  qcow2: Return real error code in qcow2_write_snapshots
>  qcow2: Update snapshot table information at once
>  qcow2: Cleanups and memleak fix in qcow2_snapshot_create
>  qcow2: Rework qcow2_snapshot_create error handling
>  qcow2: Return real error in qcow2_snapshot_goto
>  qcow2: Fix order of refcount updates in qcow2_snapshot_goto
>  qcow2: Fix order in qcow2_snapshot_delete
>  qcow2: Fix error path in qcow2_snapshot_load_tmp
>
>  block/qcow2-refcount.c |    7 +-
>  block/qcow2-snapshot.c |  330 
> +++++++++++++++++++++++++++++++++++-------------
>  block/qcow2.c          |    5 +-
>  3 files changed, 248 insertions(+), 94 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

I left a comment asking about bdrv_flush(bs->file) versus explicitly
flushing the qcow2 cache, but it's a wider question that later patches
could address, if necessary.