[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option |
Date: |
Thu, 26 Jan 2012 19:40:38 +0000 |
On 23 January 2012 07:20, Peter A. G. Crosthwaite
<address@hidden> wrote:
> --- a/vl.c
> +++ b/vl.c
> @@ -233,6 +233,7 @@ int boot_menu;
> uint8_t *boot_splash_filedata;
> int boot_splash_filedata_size;
> uint8_t qemu_extra_params_fw[2];
> +const char *qemu_kerndtb = NULL;
>
> typedef struct FWBootEntry FWBootEntry;
>
> @@ -2437,6 +2438,9 @@ int main(int argc, char **argv, char **envp)
> case QEMU_OPTION_kernel:
> kernel_filename = optarg;
> break;
> + case QEMU_OPTION_kerndtb:
> + qemu_kerndtb = optarg;
> + break;
> case QEMU_OPTION_append:
> kernel_cmdline = optarg;
> break;
This is inconsistent with how we handle kernel_filename
and initrd_filename (throwing things around via random
globals is a pretty nasty interface).
I think I like the approach Grant Likely suggested of
cleaning up the machine->init function signature so we
just pass it a struct instead.
Also missing the mollyguard on attempting to use -kernel-dtb
but not -kernel (cf the check done for -append and -initrd).
-- PMM
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, (continued)
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, Markus Armbruster, 2012/01/27
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, Peter Crosthwaite, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, John Williams, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, John Williams, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, Anthony Liguori, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, John Williams, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, Anthony Liguori, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, John Williams, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, Anthony Liguori, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option, Anthony Liguori, 2012/01/29
- Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option,
Peter Maydell <=
Message not available
Message not available