[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pc
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr. |
Date: |
Mon, 13 Feb 2012 14:53:50 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 13, 2012 at 12:20:13PM +0000, Anthony PERARD wrote:
> Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist.
> But
> this should be the jobs of a caller. In fact, the two callers of this function
> will try to retrieve the PCIBus related to the devaddr and return an error if
> they cannot.
>
> Signed-off-by: Anthony PERARD <address@hidden>
I agree. It's a good patch. And this will help address the bridges.
Want me to queue this?
> ---
> hw/pci.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index ebb5de9..da7cf79 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -529,10 +529,6 @@ int pci_parse_devaddr(const char *addr, int *domp, int
> *busp,
> if (*e)
> return -1;
>
> - /* Note: QEMU doesn't implement domains other than 0 */
> - if (!pci_find_bus(pci_find_root_bus(dom), bus))
> - return -1;
> -
> *domp = dom;
> *busp = bus;
> *slotp = slot;
> --
> Anthony PERARD
- [Qemu-devel] [PATCH V6 00/11] Xen PCI Passthrough, Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 02/11] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC., Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 04/11] configure: Introduce --enable-xen-pci-passthrough., Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 01/11] pci_ids: Add INTEL_82599_VF id., Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE, Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 05/11] Introduce HostPCIDevice to access a pci device on the host., Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 06/11] pci.c: Add pci_check_bar_overlap, Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 09/11] Introduce apic-msidef.h, Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 07/11] Introduce Xen PCI Passthrough, qdevice (1/3), Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr., Anthony PERARD, 2012/02/13
- Re: [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr.,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH V6 08/11] Introduce Xen PCI Passthrough, PCI config space helpers (2/3), Anthony PERARD, 2012/02/13
- [Qemu-devel] [PATCH V6 10/11] Introduce Xen PCI Passthrough, MSI (3/3), Anthony PERARD, 2012/02/13