|
From: | Supriya Kannery |
Subject: | Re: [Qemu-devel] [RFC Patch 5/7]Qemu: raw-posix image file reopen |
Date: | Mon, 13 Feb 2012 18:42:38 +0530 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110817 Fedora/3.1.12-1.fc14 Thunderbird/3.1.12 |
On 02/02/2012 05:45 AM, Michael Roth wrote:
On 01/31/2012 09:07 PM, Supriya Kannery wrote:raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here.
+ + /* Flags that can be set using fcntl */ + int fcntl_flags = BDRV_O_NOCACHE; + + if ((bs->open_flags& ~fcntl_flags) == (flags& ~fcntl_flags)) { + if ((flags& BDRV_O_NOCACHE)) { + s->open_flags |= O_DIRECT; + } else { + s->open_flags&= ~O_DIRECT; + } + printf("O_DIRECT flag\n"); + ret = fcntl_setfl(s->fd, s->open_flags);raw-posix.c:raw_aio_submit() does some extra alignment work if s->aligned_buf was set due to the image being opened O_DIRECT initially, not sure what the impact is but probably want to clean that up here.
ok, will check on this thanks! for reviewing Supriya
[Prev in Thread] | Current Thread | [Next in Thread] |