[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event |
Date: |
Wed, 22 Feb 2012 14:23:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 |
Am 22.02.2012 13:53, schrieb Luiz Capitulino:
> On Mon, 20 Feb 2012 09:28:15 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
>>
>>> The event name changed, which caused the subject to change too, hope this
>>> won't cause confusion.
>>>
>>> v3
>>>
>>> o Rename the event to DEVICE_TRAY_MOVED
>>> o Rename the 'ejected' event data to 'tray-open'
>>> o Only call bdrv_eject() if the tray state changed
>>> o Drop ide_tray_state_post_load()
>>
>> Reviewed-by: Markus Armbruster <address@hidden>
>
> Kevin, I'd like to get your ack before applying it to the qmp branch.
Acked-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH 2/5] block: bdrv_eject(): Make eject_flag a real bool, (continued)
- [Qemu-devel] [PATCH 2/5] block: bdrv_eject(): Make eject_flag a real bool, Luiz Capitulino, 2012/02/17
- [Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change, Luiz Capitulino, 2012/02/17
- [Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load(), Luiz Capitulino, 2012/02/17
- [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event, Luiz Capitulino, 2012/02/17
- Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event, Markus Armbruster, 2012/02/20