Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

[Jason Baron]

On Wed, Mar 07, 2012 at 09:59:58AM -0800, Roland McGrath wrote:
> On Wed, Mar 7, 2012 at 9:00 AM, Jason Baron <address@hidden> wrote:
> > +       if (vma_name) {
> > +               if ((strcmp(vma_name, "[vdso]") == 0) ||
> > +                   (strcmp(vma_name, "[vectors]") == 0) ||
> > +                   (strcmp(vma_name, "[vsyscall]") == 0))
> 
> That's just disgusting.

well, sure, we can provide an arch interface, for this check. I'm more
concerned with the general idea. If it seems ok, I can re-do this bit
with an arch interface.

Thanks,

-Jason