|
From: | Amos Kong |
Subject: | Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start() |
Date: | Wed, 14 Mar 2012 15:51:01 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 14/03/12 15:27, Paolo Bonzini wrote:
Hi Paolo,
Il 14/03/2012 08:14, Orit Wasserman ha scritto:if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) { closesocket(*fd); return -socket_error(); } return 0; and than you will not need retBut closesocket could clobber socket_error(), no?
Yes, it will effect socket_error() How about this fix ? ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)); if (ret < 0) { ret = -socket_error(); closesocket(*fd); } return ret; } -- Amos.
[Prev in Thread] | Current Thread | [Next in Thread] |