[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start() |
Date: |
Wed, 14 Mar 2012 12:39:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
Am 14.03.2012 08:51, schrieb Amos Kong:
> On 14/03/12 15:27, Paolo Bonzini wrote:
>>
>
> Hi Paolo,
>
>> Il 14/03/2012 08:14, Orit Wasserman ha scritto:
>>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0)
>>> {
>>> closesocket(*fd);
>>> return -socket_error();
>>> }
>>> return 0;
>>>
>>> and than you will not need ret
>>
>> But closesocket could clobber socket_error(), no?
>
> Yes, it will effect socket_error()
>
> How about this fix ?
>
> ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr));
> if (ret < 0) {
> ret = -socket_error();
> closesocket(*fd);
> }
> return ret;
> }
>
But it's still moved (or in this patch copied) code, right?
If so, please move it in one patch, and then fix it in another one on top.
Kevin
- [Qemu-devel] [PATCH v3 2/9] net: use tcp_server_start() for tcp server creation, (continued)
[Qemu-devel] [PATCH v3 3/9] net: introduce tcp_client_start(), Amos Kong, 2012/03/06
Re: [Qemu-devel] [PATCH v3 3/9] net: introduce tcp_client_start(), Orit Wasserman, 2012/03/14
[Qemu-devel] [PATCH v3 4/9] net: use tcp_client_start for tcp client creation, Amos Kong, 2012/03/06
[Qemu-devel] [PATCH v3 6/9] net: use getaddrinfo() in tcp_start_common, Amos Kong, 2012/03/06
[Qemu-devel] [PATCH v3 7/9] net: introduce parse_host_port_info(), Amos Kong, 2012/03/06
[Qemu-devel] [PATCH v3 5/9] net: refector tcp_*_start functions, Amos Kong, 2012/03/06
[Qemu-devel] [PATCH v3 8/9] net: split hostname and service by last colon, Amos Kong, 2012/03/06