[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code |
Date: |
Wed, 21 Mar 2012 14:59:00 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 29, 2012 at 02:35:14PM +1300, Alexey Korolev wrote:
> Hi,
>
> There is a typo in i440FX init code. This is causing problems when
> somebody wants to access 64bit PCI range.
>
>
> Signed-off-by: Alexey Korolev <address@hidden>
I've fixed the commit message and applied.
How does one trigger the problem?
I'd like to know so I can test for it.
> ---
>
> hw/piix_pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 3ed3d90..aab8188 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -353,7 +353,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int
> *piix3_devfn,
> b = i440fx_common_init("i440FX", pi440fx_state, piix3_devfn, isa_bus,
> pic,
> address_space_mem, address_space_io, ram_size,
> pci_hole_start, pci_hole_size,
> - pci_hole64_size, pci_hole64_size,
> + pci_hole64_start, pci_hole64_size,
> pci_memory, ram_memory);
> return b;
> }
>
>
>
>