[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fix '-cpu ?' Segfault
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH] fix '-cpu ?' Segfault |
Date: |
Fri, 23 Mar 2012 22:37:04 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 23, 2012 at 03:31:48PM -0500, Michael Roth wrote:
> On Thu, Mar 22, 2012 at 09:28:16AM -0400, Stefan Berger wrote:
> > On 03/21/2012 08:33 AM, Eduardo Habkost wrote:
> > >Fix stupid copy&paste mistake at commit
> > >ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
> > >"optarg" on the cpu_list() call.
> > >
> > >Reported-by: Jiri Denemark<address@hidden>
> > >Signed-off-by: Eduardo Habkost<address@hidden>
> > >---
> > > vl.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > >diff --git a/vl.c b/vl.c
> > >index 112b0e0..0fccf50 100644
> > >--- a/vl.c
> > >+++ b/vl.c
> > >@@ -3196,7 +3196,7 @@ int main(int argc, char **argv, char **envp)
> > > cpudef_init();
> > >
> > > if (cpu_model&& *cpu_model == '?') {
> > >- list_cpus(stdout,&fprintf, optarg);
> > >+ list_cpus(stdout,&fprintf, cpu_model);
> > > exit(0);
> > > }
> > >
> > Does -cpu ? actually work then? I only see the list of cpus when
> > using -cpu ?_ for example.
use "-cpu \?"
>
> I think this is actually just a shell issue:
>
> address@hidden:~/tmp/empty$ ls
> address@hidden:~/tmp/empty$ echo ?
> ?
> address@hidden:~/tmp/empty$ touch a
> address@hidden:~/tmp/empty$ echo ?
> a
> address@hidden:~/tmp/empty$ echo ?_
> ?_
>
> >
> > Stefan
> >
> >
>