[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey
Date: Thu, 07 Jun 2012 12:51:07 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 06/06/2012 07:58 PM, Eric Blake wrote:
On 06/06/2012 01:13 AM, Amos Kong wrote:

Ho, I found another bug in my code, key in decimal or hexadecimal
format is not supported. I will fix it.

How do you plan to support decimal in QMP?

In old do_sendkey(), only key-name and hexadecimal were supported,
the description needs to be fixed.

It seems we can only support key-name for QMP, and support
for HMP. Is it acceptable?

Yes, that was my argument for bare minimum support - anyone using QMP
(like libvirt) will have to be smart enough to use key-name only, while
anyone using HMP will be able to use hex because HMP will convert hex to
key-name at the appropriate time before calling into QMP.

Of course, being able to support hex from QMP would be a nice feature,
but I'm not sure how to add it in.

Why is it a nice feature?

I don't quite understand why anyone would want to use hex actually... You would have to convert from whatever symbolic code you're using to QEMU's hex value so why not just stay in symbolic representation.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]