Re: [Qemu-devel] [RFC PATCH 4/4] qapi: Convert info snapshots

[Eric Blake]

On 07/12/2012 10:55 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---

> +++ b/qapi-schema.json
> @@ -934,6 +934,41 @@
>  { 'command': 'query-block-jobs', 'returns': ['BlockJobInfo'] }
>  
>  ##
> +# @SnapshotInfo:
> +#
> +# Snapshot list.  This structure contains list of snapshots for virtual 
> machine.
> +#
> +# @id: id of the snapshot.
> +#
> +# @tag: human readable tag of the snapshot.

Tag was optional on creation, should that field be marked optional and
omitted on output when there was no tag on input?

> +#
> +# @vm_size: size of the snapshot in Bytes.
> +#
> +# @date: date and time of the snapshot as timestamp.

What type of timestamp?  Seconds since Epoch?

> +#
> +# @vm_clock: time in the guest in nsecs.

If vm_clock is in nsecs, should we also be reporting sub-second
resolution in date?

> +SQMP
> +query-snapshots
> +----------
> +
> +List available snapshots for VM.
> +
> +Return a json-object with the following information:

Returns an array of json-objects, each with the following information:

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature