[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open(). |
Date: |
Tue, 07 Aug 2012 14:40:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/07/2012 02:30 PM, Blue Swirl wrote:
> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet <address@hidden> wrote:
>> Signed-off-by: Benoit Canet <address@hidden>
>> ---
>> block/quorum.c | 62
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 62 insertions(+)
>>
>> diff --git a/block/quorum.c b/block/quorum.c
>> index e0405b6..de58ab8 100644
>> --- a/block/quorum.c
>> +++ b/block/quorum.c
>> @@ -47,11 +47,73 @@ struct QuorumAIOCB {
>> int vote_ret;
>> };
>>
>> +/* Valid quorum filenames look like
>> + * quorum:path/to/a_image:path/to/b_image:path/to/c_image
>
> This syntax would mean that stacking for example curl or other network
> paths would not be possible. How about comma as separator?
Also, what escaping mechanism is in place for allowing a file containing
the same character as the separator (whether you end up with : or , as
the separator)? If you support a larger quorum (whether always n/(2n-1)
or whether fully configurable n/m), rather than hard-coded 2/3, then you
also need a way to specify how many quorum members will follow.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open()., Stefan Hajnoczi, 2012/08/08
[Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close()., Benoît Canet, 2012/08/07
[Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength()., Benoît Canet, 2012/08/07