[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_io
From: |
Xu, Dongxiao |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move |
Date: |
Mon, 17 Sep 2012 23:18:49 +0000 |
Hi Stefano,
Is these patches merged with Xen 4.2? I didn't see them in the upstream.
The uint/int fix is critical to fix the nested guest boot issue.
Thanks,
Dongxiao
> -----Original Message-----
> From: Stefano Stabellini [mailto:address@hidden
> Sent: Tuesday, September 11, 2012 2:05 AM
> To: address@hidden
> Cc: Xu, Dongxiao; Ian Jackson; address@hidden; Stefano Stabellini
> Subject: [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move
>
> Hi all,
> after reviewing the patch "fix multiply issue for int and uint types"
> with Ian Jackson, we realized that cpu_ioreq_pio and cpu_ioreq_move are in
> much need for a simplification as well as removal of a possible integer
> overflow.
>
> This patch series tries to accomplish both switching to two new helper
> functions and using a more obvious arithmetic. Doing so it should also fix the
> original problem that Dongxiao was experiencing. The C language can be a
> nasty backstabber when signed and unsigned integers are involved.
>
> The current patch series if for qemu-xen-traditional but if the patches are
> deemed correct I'll submit an equivalent set for QEMU upstream (with the
> appropriate code style changes).
>
>
>
> Stefano Stabellini (2):
> i should be uint32_t rather than int
> introduce read_physical_offset and write_physical_offset
>
> i386-dm/helper2.c | 66
> +++++++++++++++++++++++++++++++++-------------------
> 1 files changed, 42 insertions(+), 24 deletions(-)
>
>
>
> Cheers,
>
> Stefano