[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 5/6] xilinx: fix names of ethernet and dma li
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v1 5/6] xilinx: fix names of ethernet and dma links. |
Date: |
Tue, 18 Sep 2012 09:36:28 +1000 |
On Tue, Sep 18, 2012 at 1:13 AM, Andreas Färber <address@hidden> wrote:
> Hi,
>
> Am 17.09.2012 10:47, schrieb Peter A. G. Crosthwaite:
>> These names were incorrect. Fixed to match to actual link names
>>
>> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
>> ---
>> hw/xilinx.h | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/xilinx.h b/hw/xilinx.h
>> index 4d29265..6449bd4 100644
>> --- a/hw/xilinx.h
>> +++ b/hw/xilinx.h
>> @@ -63,7 +63,8 @@ xilinx_axiethernet_create(NICInfo *nd, StreamSlave *peer,
>> qdev_set_nic_properties(dev, nd);
>> qdev_prop_set_uint32(dev, "rxmem", rxmem);
>> qdev_prop_set_uint32(dev, "txmem", txmem);
>> - object_property_set_link(OBJECT(dev), OBJECT(peer), "tx_dev", &errp);
>> + object_property_set_link(OBJECT(dev), OBJECT(peer),
>> "axistream-connected",
>> + &errp);
>> assert_no_error(errp);
>> qdev_init_nofail(dev);
>> sysbus_mmio_map(sysbus_from_qdev(dev), 0, base);
>> @@ -80,7 +81,8 @@ xilinx_axiethernetdma_init(DeviceState *dev, StreamSlave
>> *peer,
>> Error *errp = NULL;
>>
>> qdev_prop_set_uint32(dev, "freqhz", freqhz);
>> - object_property_set_link(OBJECT(dev), OBJECT(peer), "tx_dev", &errp);
>> + object_property_set_link(OBJECT(dev), OBJECT(peer),
>> "axistream-connected",
>> + &errp);
>> assert_no_error(errp);
>> qdev_init_nofail(dev);
>>
>
> Indentation of &errp looks odd despite no tabs - intentional?
>
I have indented to the first multiple of 4 spaces after the function
opening brace. Is there a prescribed way? Can it be added to
CODING_STYLE and checkpatch if there is a particular recommended way?
Regards,
Peter
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v1 0/6] Microblaze Patches, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [PATCH v1 1/6] xilinx_timer: Removed comma in device name, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [PATCH v1 3/6] xilinx_timer: Fixed "frequency" prop name, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [PATCH v1 2/6] xilinx_timer: Send dbg msgs to stderr not stdout, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [PATCH v1 4/6] xilinx.h: Error check when setting links, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [PATCH v1 5/6] xilinx: fix names of ethernet and dma links., Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [PATCH v1 6/6] xilinx_timer: Fix a compile error if debug enabled, Peter A. G. Crosthwaite, 2012/09/17
- Re: [Qemu-devel] [PATCH v1 0/6] Microblaze Patches, Edgar E. Iglesias, 2012/09/19