[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] tcg: Add tcg_debug_assert
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] tcg: Add tcg_debug_assert |
Date: |
Sat, 22 Sep 2012 21:52:07 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Sep 21, 2012 at 05:18:14PM -0700, Richard Henderson wrote:
> Like the C assert macro, except only enabled for CONFIG_DEBUG_TCG,
> and without having to set _NDEBUG and disable all other asserts at
> the same time.
>
> The use of __builtin_unreachable (when available) gives the compiler
> the same information, which may (or may not) help it optimize better.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/tcg.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tcg/tcg.h b/tcg/tcg.h
> index 48a56f0..4501c15 100644
> --- a/tcg/tcg.h
> +++ b/tcg/tcg.h
> @@ -530,6 +530,15 @@ do {\
> abort();\
> } while (0)
>
> +#ifdef CONFIG_DEBUG_TCG
> +# define tcg_debug_assert(X) do { assert(X); } while (0)
> +#elif QEMU_GNUC_PREREQ(4, 5)
> +# define tcg_debug_assert(X) \
> + do { if (!(X)) { __builtin_unreachable(); } } while (0)
> +#else
> +# define tcg_debug_assert(X) do { (void)(X); } while (0)
> +#endif
> +
> void tcg_add_target_add_op_defs(const TCGTargetOpDef *tdefs);
>
> #if TCG_TARGET_REG_BITS == 32
> --
> 1.7.11.4
>
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 2/8] tcg: Emit ANDI as EXTU for appropriate constants, (continued)
- [Qemu-devel] [PATCH 2/8] tcg: Emit ANDI as EXTU for appropriate constants, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 3/8] tcg: Optimize initial inputs for ori_i64, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 4/8] tcg: Emit XORI as NOT for appropriate constants, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 5/8] tcg: Implement concat*_i64 with deposit_i64, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 6/8] tcg: Add tcg_debug_assert, Richard Henderson, 2012/09/21
- Re: [Qemu-devel] [PATCH 6/8] tcg: Add tcg_debug_assert,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 7/8] tcg: Sanity check deposit inputs, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 8/8] tcg: Sanity check goto_tb input, Richard Henderson, 2012/09/21
- Re: [Qemu-devel] [PATCH 0/8] Misc tcg improvements, Aurelien Jarno, 2012/09/25