[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/8] tcg: Implement concat*_i64 with deposit_i64
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 5/8] tcg: Implement concat*_i64 with deposit_i64 |
Date: |
Mon, 24 Sep 2012 08:38:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 2012-09-22 12:52, Aurelien Jarno wrote:
> On Fri, Sep 21, 2012 at 05:18:13PM -0700, Richard Henderson wrote:
>> For tcg_gen_concat_i32_i64 we only use deposit if the host supports it.
>> For tcg_gen_concat32_i64 even if the host does not, as we get identical
>> code before and after.
>>
>> Note that this relies on the ANDI -> EXTU patch for the identity claim.
>
> I don't really get why, andi is not used in this patch.
No, but tcg_gen_deposit uses andi in its fallback implementation.
r~
- Re: [Qemu-devel] [PATCH 1/8] tcg: Adjust descriptions of *cond opcodes, (continued)
- [Qemu-devel] [PATCH 2/8] tcg: Emit ANDI as EXTU for appropriate constants, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 3/8] tcg: Optimize initial inputs for ori_i64, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 4/8] tcg: Emit XORI as NOT for appropriate constants, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 5/8] tcg: Implement concat*_i64 with deposit_i64, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 6/8] tcg: Add tcg_debug_assert, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 7/8] tcg: Sanity check deposit inputs, Richard Henderson, 2012/09/21
- [Qemu-devel] [PATCH 8/8] tcg: Sanity check goto_tb input, Richard Henderson, 2012/09/21
- Re: [Qemu-devel] [PATCH 0/8] Misc tcg improvements, Aurelien Jarno, 2012/09/25