[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/17] aio: change qemu_aio_set_fd_handler to re
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 04/17] aio: change qemu_aio_set_fd_handler to return void |
Date: |
Tue, 25 Sep 2012 16:47:31 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Paolo Bonzini <address@hidden> writes:
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Regards,
Anthony Liguori
> ---
> aio.c | 12 +++++-------
> qemu-aio.h | 10 +++++-----
> 2 file modificati, 10 inserzioni(+), 12 rimozioni(-)
>
> diff --git a/aio.c b/aio.c
> index c738a4e..e062aab 100644
> --- a/aio.c
> +++ b/aio.c
> @@ -53,11 +53,11 @@ static AioHandler *find_aio_handler(int fd)
> return NULL;
> }
>
> -int qemu_aio_set_fd_handler(int fd,
> - IOHandler *io_read,
> - IOHandler *io_write,
> - AioFlushHandler *io_flush,
> - void *opaque)
> +void qemu_aio_set_fd_handler(int fd,
> + IOHandler *io_read,
> + IOHandler *io_write,
> + AioFlushHandler *io_flush,
> + void *opaque)
> {
> AioHandler *node;
>
> @@ -93,8 +93,6 @@ int qemu_aio_set_fd_handler(int fd,
> }
>
> qemu_set_fd_handler2(fd, NULL, io_read, io_write, opaque);
> -
> - return 0;
> }
>
> void qemu_aio_flush(void)
> diff --git a/qemu-aio.h b/qemu-aio.h
> index bfdd35f..27a7e21 100644
> --- a/qemu-aio.h
> +++ b/qemu-aio.h
> @@ -60,10 +60,10 @@ bool qemu_aio_wait(void);
> * Code that invokes AIO completion functions should rely on this function
> * instead of qemu_set_fd_handler[2].
> */
> -int qemu_aio_set_fd_handler(int fd,
> - IOHandler *io_read,
> - IOHandler *io_write,
> - AioFlushHandler *io_flush,
> - void *opaque);
> +void qemu_aio_set_fd_handler(int fd,
> + IOHandler *io_read,
> + IOHandler *io_write,
> + AioFlushHandler *io_flush,
> + void *opaque);
>
> #endif
> --
> 1.7.12
- [Qemu-devel] [RFC PATCH 00/17] Support for multiple "AIO contexts", Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 01/17] build: do not rely on indirect inclusion of qemu-config.h, Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 03/17] event_notifier: add Win32 implementation, Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 02/17] event_notifier: enable it to use pipes, Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 04/17] aio: change qemu_aio_set_fd_handler to return void, Paolo Bonzini, 2012/09/25
- Re: [Qemu-devel] [PATCH 04/17] aio: change qemu_aio_set_fd_handler to return void,
Anthony Liguori <=
- [Qemu-devel] [PATCH 06/17] aio: introduce AioContext, move bottom halves there, Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 05/17] aio: provide platform-independent API, Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 07/17] aio: add I/O handlers to the AioContext interface, Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 08/17] aio: add non-blocking variant of aio_wait, Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 10/17] aio: add Win32 implementation, Paolo Bonzini, 2012/09/25
- [Qemu-devel] [PATCH 09/17] aio: prepare for introducing GSource-based dispatch, Paolo Bonzini, 2012/09/25