|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 06/17] aio: introduce AioContext, move bottom halves there |
Date: | Wed, 26 Sep 2012 08:30:51 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 25/09/2012 23:51, Anthony Liguori ha scritto: >> > typedef struct QEMUTimer QEMUTimer; >> > typedef struct QEMUFile QEMUFile; >> > +typedef struct QEMUBH QEMUBH; >> > typedef struct DeviceState DeviceState; >> > >> > struct Monitor; > Any reason to do this here vs. just #include "qemu-aio.h" in > qemu-common.h? > > I don't see an obvious dependency on qemu-common.h in qemu-aio.h other > than this typedef. I thought we were moving away from including everything in qemu-common.h. In fact, the only includes from QEMU in qemu-common.h are: #ifdef _WIN32 #include "qemu-os-win32.h" #endif #ifdef CONFIG_POSIX #include "qemu-os-posix.h" #endif #include "osdep.h" #include "bswap.h" #include "cpu.h" where cpu.h could probably be removed---perhaps should. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |