[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMach
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine |
Date: |
Wed, 21 Nov 2012 13:35:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 |
On 21/11/12 13:07, Igor Mitsyanko wrote:
> This version of patch doesn't change anything for majority of machines, its
> just that later we can
> choose ourself which default block interface to use. So, nothing to review
> from Exynos point of view, but patch
> is OK, except realview_pb_a8 part (see bellow):
>
> Acked-by: Igor Mitsyanko <address@hidden>
>
>
> On 11/20/2012 06:30 PM, Christian Borntraeger wrote:
>
>> @@ -379,13 +379,14 @@ static QEMUMachine realview_pb_a8_machine = {
>> .name = "realview-pb-a8",
>> .desc = "ARM RealView Platform Baseboard for Cortex-A8",
>> .init = realview_pb_a8_init,
>> + .block_default_type = IF_SCSI,
>> };
>>
>
>
> I think that's an unintentional change?
Indeed.
Kevin, Stefan, in case of no other findings, can you fix that hunk yourself or
do
you want a new patch?
Christian
- [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Christian Borntraeger, 2012/11/20
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Alexander Graf, 2012/11/20
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Igor Mitsyanko, 2012/11/21
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Markus Armbruster, 2012/11/22
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Christian Borntraeger, 2012/11/22
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Markus Armbruster, 2012/11/22
- [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface, Christian Borntraeger, 2012/11/22
- [Qemu-devel] [PATCH 1/2] block: simply default_drive, Christian Borntraeger, 2012/11/22
- [Qemu-devel] [PATCH 2/2] block: clarify comment about IF_IDE = 0, Christian Borntraeger, 2012/11/22
- Re: [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface, Stefan Hajnoczi, 2012/11/23
- Re: [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface, Markus Armbruster, 2012/11/23
- Re: [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface, Stefan Hajnoczi, 2012/11/23
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Stefan Hajnoczi, 2012/11/22