qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMach


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine
Date: Thu, 22 Nov 2012 15:05:00 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Christian Borntraeger <address@hidden> writes:

> On 22/11/12 13:02, Markus Armbruster wrote:
>
> Thanks for the review, Stefan already applied the patch, though.
> Is there anything that you really want to have a followup patch
> besides this one?

"Really want" is too strong, but improving the comment on the definition
of IF_IDE would be nice.

>> There's just one caller that passes IF_DEFAULT.  We could change it to
>> pass machine->block_default_type instead, and drop parameter
>> block_default_type.  Follow-up patch.
>
> I will have a look on that.

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]