[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V10 1/7] Buildsystem fix distclean error for pix
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH V10 1/7] Buildsystem fix distclean error for pixman |
Date: |
Wed, 21 Nov 2012 22:54:45 +0000 |
On 20 November 2012 09:46, Wenchao Xia <address@hidden> wrote:
> Currently Makefile test if pixman have configure log, but the script
> directly
> return error if that file do not exist. This patch fix it.
>
> v2: print out the command.
We need this patch in 1.3 because otherwise 'distclean' barfs
if you're using internal pixman. This would be clearer if it
was a separate patch and not part of this libqblock series
(which is not for 1.3 as far as I know).
> Signed-off-by: Wenchao Xia <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 3e8d441..9ecbcbb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -286,7 +286,7 @@ distclean: clean
> for d in $(TARGET_DIRS) $(QEMULIBS); do \
> rm -rf $$d || exit 1 ; \
> done
> - test -f pixman/config.log && make -C pixman distclean
> + if test -f pixman/config.log; then make -C pixman distclean; fi
>
> KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \
> ar de en-us fi fr-be hr it lv nl pl ru th \
> --
> 1.7.1
>
[Qemu-devel] [PATCH V10 5/7] libqblock type defines, Wenchao Xia, 2012/11/20