[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] net: make netclient re-entrant with refc
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] net: make netclient re-entrant with refcnt |
Date: |
Tue, 12 Mar 2013 09:45:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
Il 07/03/2013 03:53, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <address@hidden>
>
> With refcnt, NetClientState's caller can run agaist reclaimer.
>
> Signed-off-by: Liu Ping Fan <address@hidden>
> ---
> hw/qdev-properties-system.c | 14 +++++++++++++
> include/net/net.h | 3 ++
> net/hub.c | 3 ++
> net/net.c | 46 ++++++++++++++++++++++++++++++++++++++++--
> net/slirp.c | 3 +-
> 5 files changed, 65 insertions(+), 4 deletions(-)
The patch makes sense, but the commit message does not yet.
Please add documentation to include/net/net.h, specifying the functions
that add a reference to the returned NetClientState.
Paolo
- Re: [Qemu-devel] [PATCH v2 1/5] net: spread hub on AioContexts, (continued)
[Qemu-devel] [PATCH v2 5/5] net: make netclient re-entrant with refcnt, Liu Ping Fan, 2013/03/06
- Re: [Qemu-devel] [PATCH v2 5/5] net: make netclient re-entrant with refcnt,
Paolo Bonzini <=