[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with N
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename |
Date: |
Tue, 19 Mar 2013 20:14:08 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/18/2013 11:23 AM, Kevin Wolf wrote:
> In order to achieve this, the .bdrv_probe callbacks of all drivers must
> cope with this. The DMG driver is the only one that bases its decision
> on the filename and it needs to be changed.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/dmg.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/dmg.c b/block/dmg.c
> index c1066df..3141cb5 100644
> --- a/block/dmg.c
> +++ b/block/dmg.c
> @@ -51,9 +51,16 @@ typedef struct BDRVDMGState {
>
> static int dmg_probe(const uint8_t *buf, int buf_size, const char *filename)
> {
> - int len=strlen(filename);
> - if(len>4 && !strcmp(filename+len-4,".dmg"))
Someone really didn't like whitespace :) Glad to see it rewritten to
keep the patch checker happy.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 03/11] qemu-socket: Make socket_optslist public, (continued)
- [Qemu-devel] [PATCH 04/11] nbd: Keep hostname and port separate, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 01/11] block: Add options QDict to bdrv_file_open() prototypes, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename, Kevin Wolf, 2013/03/18
- Re: [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename,
Eric Blake <=
- [Qemu-devel] [PATCH 07/11] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 06/11] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 10/11] block: Allow omitting the file name when using driver-specific options, Kevin Wolf, 2013/03/18