[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory
From: |
Michael Walle |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself |
Date: |
Thu, 28 Mar 2013 19:37:03 +0100 |
User-agent: |
KMail/1.13.5 (Linux/2.6.32-5-686-bigmem; KDE/4.4.5; i686; ; ) |
Am Donnerstag 28 März 2013, 19:33:48 schrieb Peter Maydell:
> On 28 March 2013 18:31, Michael Walle <address@hidden> wrote:
> > Am Donnerstag 28 März 2013, 18:55:59 schrieb Anthony Liguori:cc>
> >
> >> Breaks the build:
> >>
> >> address@hidden qemu]$ make
> >>
> >> CC lm32-softmmu/hw/lm32/../milkymist-softusb.o
> >>
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c: In function
> >> ‘softusb_mouse_hid_datain’:
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:183:38: error:
> >> ‘m’ may be used uninitialized in this function
> >> [-Werror=maybe-uninitialized]
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:179:13: note:
> >> ‘m’ was declared here
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c: In function
> >> ‘softusb_kbd_hid_datain’:
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:197:38: error:
> >> ‘m’ may be used uninitialized in this function
> >> [-Werror=maybe-uninitialized]
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:193:13: note:
> >> ‘m’ was declared here cc1: all warnings being treated as errors
> >> make[1]: *** [hw/lm32/../milkymist-softusb.o] Error 1
> >
> > are you sure, this patch breaks the build, or was is broken before?
> >
> > i'll send a patch soon.
>
> My compiler doesn't complain. I suspect you may be right and
> the problem was already there. Anyway I think that adding
> a 'memset(buf, 0, len);' after the error_report() calls
> in softusb_read_pmem()/softusb_read_dmem() will fix it.
Sounds good. Are you fixing it, or should i send a patch?
--
michael
[Qemu-devel] [PATCH v3 5/5] sysbus: Remove sysbus_add_memory and sysbus_del_memory, Peter Maydell, 2013/03/15
[Qemu-devel] [PATCH v3 3/5] milkymist-minimac2: Just expose buffers as a sysbus mmio region, Peter Maydell, 2013/03/15
[Qemu-devel] [PATCH v3 2/5] musicpal: qdevify musicpal-misc, Peter Maydell, 2013/03/15
Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory, Paolo Bonzini, 2013/03/15
Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory, Peter Maydell, 2013/03/28