[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED st
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state |
Date: |
Wed, 24 Apr 2013 20:56:19 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/24/2013 08:25 PM, Lei Li wrote:
> On 04/24/2013 10:57 PM, Eric Blake wrote:
>> On 04/24/2013 04:12 AM, Lei Li wrote:
>>> Signed-off-by: Lei Li <address@hidden>
>>> ---
>>> docs/vnc-ledstate-Pseudo-encoding.txt | 40
>>> +++++++++++++++++++++++++++++++++
>>> 1 files changed, 40 insertions(+), 0 deletions(-)
>>> create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt
>>>
>>> +
>>> +The Pseudo-encoding number for LED state defined as:
>>> +
>>> +======= ===============================================================
>>> +Number Name
>>> +======= ===============================================================
>>> +-261 'LED state Pseudo-encoding'_
>> Is the trailing _ intentional?
>
> Yes, add this trailing '_' to indicate that this is a quoted context and
> you can
> locate its section somewhere.
> I saw this style used in RFB protocol, but it's not necessary. I'd get
> rid of it
> if you don't like it. :)
I didn't read the RFB protocol; if you are being consistent with a
parent document that you are extending, then by all means use the same
conventions.
>> Which bit is which? Is bit 0 the Caps lock LED?
>
> Caps lock key is represented as '100', and Scroll lock key is
> represented as '001'.
> Sorry, I should describe it more clearly.
Yep, especially since your choice of encoding was opposite to mine. A
good protocol should be easy to implement. I don't care which order the
bits go in, as long as everyone treats the same bit as caps lock based
on good docs.
> Or maybe I should include the example of the encodings defined?
In my opinion, adding an example will never hurt :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature