[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific |
Date: |
Tue, 14 May 2013 22:06:43 +0100 |
On 14 May 2013 19:30, Brad Smith <address@hidden> wrote:
> On Tue, May 14, 2013 at 02:05:21PM +0200, Paolo Bonzini wrote:
>> This should fix building the GTK+ front-end on BSDs.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> include/qemu-common.h | 12 ++++++++++++
>> qemu-char.c | 10 ----------
>> ui/gtk.c | 1 -
>> 3 files changed, 12 insertions(+), 11 deletions(-)
>
> This actually fixes the build on *BSD and OS X systems.
>
>
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index af769f5..c944bb7 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -45,6 +45,7 @@
> #if defined(__GLIBC__)
> # include <pty.h>
> #elif defined CONFIG_BSD
> +# include <termios.h>
> # if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||
> defined(__DragonFly__)
> # include <libutil.h>
> # else
>
This is going to need a Signed-off-by: if you want it to be
applied (and ideally to be a properly formatted git patch
that can be automatically applied, with a "for-1.5" tag
and cc'ing Anthony).
(I can't test it myself because my MacOSX system doesn't
have GTK so I don't build the GTK frontend anyway; it
doesn't actively break the MacOSX build, at least.)
thanks
-- PMM
Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific, Brad Smith, 2013/05/14
- Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific,
Peter Maydell <=
Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific, Peter Maydell, 2013/05/14