[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning

From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning
Date: Wed, 22 May 2013 21:40:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130513 Thunderbird/17.0.6

On 05/22/13 18:32, Michael Roth wrote:
> When this VMSD was introduced it's version fields were set to
> sizeof(I6300State), making them essentially random from build to build,
> version to version.
> To fix this, we lock in a high version id and low minimum version id to
> support old->new migration from all prior versions of this device's
> state. This should work since the device state has not changed since
> its introduction.
> The potentially breaks migration from 1.5+ to 1.5, but since the
> versioning was essentially random prior to this patch, new->old
> migration was not consistently functional to begin with.
> Reported-by: Nicholas Thomas <address@hidden>
> Suggested-by: Peter Maydell <address@hidden>
> Cc: address@hidden
> Signed-off-by: Michael Roth <address@hidden>
> ---
> v2:
>  * Fixed s/except/accept/ typo (Laszlo)
>  hw/watchdog/wdt_i6300esb.c |   19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)

Always alert to make a difference :),

Reviewed-by: Laszlo Ersek <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]