[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 repost 3/9] acpi: add rules to compile ASL so
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 repost 3/9] acpi: add rules to compile ASL source |
Date: |
Thu, 11 Jul 2013 18:58:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130621 Thunderbird/17.0.7 |
On 07/11/13 18:55, Laszlo Ersek wrote:
> On 07/10/13 15:51, Michael S. Tsirkin wrote:
>> Detect presence of IASL compiler and use it
>> to process ASL source. If not there, use pre-compiled
>> files in-tree. Add script to update the in-tree files.
>>
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
>> ---
>> configure | 9 ++++++++-
>> hw/i386/Makefile.objs | 22 ++++++++++++++++++++++
>> scripts/update-acpi.sh | 4 ++++
>> 3 files changed, 34 insertions(+), 1 deletion(-)
>> create mode 100644 scripts/update-acpi.sh
>
> I think:
> - this patch (3/9) should be swapped with the next one (4/9), so that
> the pre-generated files are available earlier than the build code
> potentially relying on them,
> - the "iasl-option" trick should be moved to ./configure perhaps.
Reviewed-by: Laszlo Ersek <address@hidden>
anyway
[Qemu-devel] [PATCH v2 repost 2/9] i386: add ACPI table files from seabios, Michael S. Tsirkin, 2013/07/10