[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 repost 1/9] hw/i386/pc.c: move IO_APIC_DEFAUL
From: |
Hu Tao |
Subject: |
Re: [Qemu-devel] [PATCH v2 repost 1/9] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h |
Date: |
Mon, 15 Jul 2013 15:11:46 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jul 10, 2013 at 04:51:35PM +0300, Michael S. Tsirkin wrote:
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Laszlo Ersek <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Duplicated signed-off-by, although this is not a problem.
Reviewed-by: Hu Tao <address@hidden>
> ---
> hw/i386/pc.c | 2 --
> include/hw/i386/apic.h | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 80c27d6..4b29685 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -75,8 +75,6 @@
> #define FW_CFG_E820_TABLE (FW_CFG_ARCH_LOCAL + 3)
> #define FW_CFG_HPET (FW_CFG_ARCH_LOCAL + 4)
>
> -#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> -
> #define E820_NR_ENTRIES 16
>
> struct e820_entry {
> diff --git a/include/hw/i386/apic.h b/include/hw/i386/apic.h
> index 1d48e02..edbb37f 100644
> --- a/include/hw/i386/apic.h
> +++ b/include/hw/i386/apic.h
> @@ -26,6 +26,8 @@ void apic_designate_bsp(DeviceState *d);
> /* pc.c */
> DeviceState *cpu_get_current_apic(void);
>
> +#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> +
> /* cpu.c */
> bool cpu_is_bsp(X86CPU *cpu);
>
> --
> MST
>
>