[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array |
|
Date: |
Fri, 04 Oct 2013 19:55:02 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
Am 04.10.2013 19:49, schrieb Peter Maydell:
> On 5 October 2013 01:57, Fabien Chouteau <address@hidden> wrote:
>
>> --- a/target-sparc/cpu-qom.h
>> +++ b/target-sparc/cpu-qom.h
>> @@ -21,7 +21,6 @@
>> #define QEMU_SPARC_CPU_QOM_H
>>
>> #include "qom/cpu.h"
>> -#include "cpu.h"
>
> ...why have you deleted this #include ?
That's removing a circular include, I guess. If I get it as a separate
patch I would apply it immediately ... well, in quotes, sorry...
Andreas
>>
>> #ifdef TARGET_SPARC64
>> #define TYPE_SPARC_CPU "sparc64-cpu"
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 0/4] Few minor improvements of monitor disas command (v4), Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands, Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 2/4] Improve Monitor disas with symbol lookup, Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/04
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/04
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/07
[Qemu-devel] [PATCH 1/4] Fix coding style, Fabien Chouteau, 2013/10/04